66ab309939
- 67 个 .cs 文件加中文注释:每个文件顶部说明职责/调用方/线程与节拍/ 已知限制/「要改什么就改哪里」,字段与方法逐条一行说明,复杂逻辑内插关键步骤 - 纯注释改动:脚本校验所有新增行都是注释、无非注释改动(仅 2 个文件的 BOM 随新头部注释下移,文件仍以 BOM 开头) - 新增 docs/代码导览.md:模块地图、「我要改 X 看哪个文件」对照表、易踩的坑、 悬浮条显示规则、测试与验收指引 - 编译通过,回归测试 23/23 通过 Co-Authored-By: Claude Code <noreply@anthropic.com>
133 lines
6.8 KiB
C#
133 lines
6.8 KiB
C#
// =====================================================================================
|
|
// TreeRefreshTests —— 控件树增量刷新(ControlTreeReconciler)的节点身份保持回归。
|
|
//
|
|
// 覆盖范围:在同一棵 System.Windows.Forms.TreeView 上反复 Apply(fresh) 时,
|
|
// 未变化的节点必须复用原 TreeNode(句柄、选中、展开状态不丢),只有真正新增/
|
|
// 删除/移动的节点才变更;RuntimeId 缺失时的回退身份不得依赖可变的 Name。
|
|
//
|
|
// 为什么这样测:用本进程自建的 TreeView 与内存快照对拍,不调用 UIA、不枚举真实窗口。
|
|
// 这里跑的是 WinForms 自身控件(安全),危险的是 UIA 自读——两者不要混淆。
|
|
//
|
|
// 新增用例:加到 Register(...) 列表并实现 private static void 方法,断言走 Check.*。
|
|
// =====================================================================================
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Windows.Forms;
|
|
using pacs_win_uia.Models;
|
|
using pacs_win_uia.UI;
|
|
|
|
namespace PacsWinUia.RegressionTests
|
|
{
|
|
internal static class TreeRefreshTests
|
|
{
|
|
public static void Register(IList<KeyValuePair<string, Action>> tests)
|
|
{
|
|
// 防:静置或仅改名时整树被重建,导致句柄/选中/展开状态丢失、Tag 未重绑。
|
|
tests.Add(new KeyValuePair<string, Action>("Tree refresh retains native items when unchanged or renamed", RetainsItems));
|
|
// 防:结构调整时误重建根节点,移动/重挂的节点丢失身份,选中与展开状态被清。
|
|
tests.Add(new KeyValuePair<string, Action>("Tree refresh applies only insert, remove and move differences", StructuralChanges));
|
|
// 防:无 RuntimeId 时的回退身份依赖可变的 Name,改名即被当成新节点。
|
|
tests.Add(new KeyValuePair<string, Action>("Tree fallback identity ignores mutable Name", FallbackIdentity));
|
|
}
|
|
|
|
private static ControlTreeReconciler.Item Item(string runtime, string name)
|
|
{
|
|
return new ControlTreeReconciler.Item
|
|
{
|
|
Model = new ControlTreeNode { Source = ControlTreeSource.Uia,
|
|
Uia = new UiaElementInfo { ProcessId = 12345, RuntimeId = runtime,
|
|
ControlType = "ControlType.Button", Name = name, ClassName = "StableClass" } },
|
|
Text = name,
|
|
ForeColor = System.Drawing.Color.Empty
|
|
};
|
|
}
|
|
|
|
private static void RetainsItems()
|
|
{
|
|
using (var tree = new TreeView())
|
|
using (var update = new ControlTreeReconciler(tree))
|
|
{
|
|
tree.CreateControl();
|
|
var matches = new List<TreeNode>();
|
|
var root = Item("1", "root");
|
|
root.Children.Add(Item("2", "before"));
|
|
update.Apply(root, matches);
|
|
TreeNode parent = tree.Nodes[0], child = parent.Nodes[0];
|
|
parent.Expand();
|
|
tree.SelectedNode = child;
|
|
IntPtr handle = child.Handle;
|
|
for (int i = 0; i < 40; i++)
|
|
{
|
|
var fresh = Item("1", "root");
|
|
fresh.Children.Add(Item("2", i < 20 ? "before" : "after"));
|
|
fresh.Children[0].Match = i >= 30;
|
|
update.Apply(fresh, matches);
|
|
Check.Same(parent, tree.Nodes[0], "Root was rebuilt");
|
|
Check.Same(child, parent.Nodes[0], "Renamed item was rebuilt");
|
|
Check.Equal(handle, child.Handle, "Native item handle changed");
|
|
Check.Same(child, tree.SelectedNode, "Selection changed");
|
|
Check.True(parent.IsExpanded, "Parent collapsed");
|
|
Check.Same(fresh.Children[0].Model, child.Tag, "Tag not rebound to fresh snapshot");
|
|
}
|
|
Check.Equal("after", child.Text, "Updated text missing");
|
|
Check.Equal(1, matches.Count, "Search matches not updated");
|
|
}
|
|
}
|
|
|
|
private static void StructuralChanges()
|
|
{
|
|
using (var tree = new TreeView())
|
|
using (var update = new ControlTreeReconciler(tree))
|
|
{
|
|
tree.CreateControl();
|
|
var matches = new List<TreeNode>();
|
|
var root = Item("1", "root");
|
|
root.Children.Add(Item("2", "A"));
|
|
root.Children.Add(Item("3", "B"));
|
|
root.Children.Add(Item("4", "C"));
|
|
update.Apply(root, matches);
|
|
TreeNode original = tree.Nodes[0], a = original.Nodes[0], b = original.Nodes[1], c = original.Nodes[2];
|
|
original.Expand();
|
|
tree.SelectedNode = b;
|
|
var fresh = Item("1", "root");
|
|
fresh.Children.Add(Item("4", "C"));
|
|
fresh.Children.Add(Item("5", "inserted"));
|
|
fresh.Children.Add(Item("3", "B renamed"));
|
|
update.Apply(fresh, matches);
|
|
Check.Same(original, tree.Nodes[0], "Root rebuilt on structural change");
|
|
Check.Same(c, original.Nodes[0], "Moved C lost identity");
|
|
Check.Same(b, original.Nodes[2], "Retained B lost identity");
|
|
Check.Equal(3, original.Nodes.Count, "Insert/delete count");
|
|
Check.True(a.TreeView == null, "Deleted A retained");
|
|
Check.Same(b, tree.SelectedNode, "Selection lost after sibling reorder");
|
|
Check.True(original.IsExpanded, "Expansion lost after reorder");
|
|
var moved = Item("1", "root");
|
|
var newParent = Item("6", "new parent");
|
|
newParent.Children.Add(Item("3", "B moved"));
|
|
moved.Children.Add(newParent);
|
|
update.Apply(moved, matches);
|
|
Check.Same(b, original.Nodes[0].Nodes[0], "Reparented item lost identity");
|
|
Check.Same(b, tree.SelectedNode, "Selection lost after reparenting");
|
|
}
|
|
}
|
|
|
|
private static void FallbackIdentity()
|
|
{
|
|
using (var tree = new TreeView())
|
|
using (var update = new ControlTreeReconciler(tree))
|
|
{
|
|
var matches = new List<TreeNode>();
|
|
var root = Item(null, "old name");
|
|
root.Children.Add(Item(null, "old child name"));
|
|
update.Apply(root, matches);
|
|
TreeNode parent = tree.Nodes[0], child = parent.Nodes[0];
|
|
var fresh = Item(null, "new name");
|
|
fresh.Children.Add(Item(null, "new child name"));
|
|
update.Apply(fresh, matches);
|
|
Check.Same(parent, tree.Nodes[0], "Fallback root depends on Name");
|
|
Check.Same(child, parent.Nodes[0], "Fallback child depends on Name");
|
|
}
|
|
}
|
|
}
|
|
}
|